From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32764 invoked by alias); 1 Oct 2014 18:07:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32753 invoked by uid 89); 1 Oct 2014 18:07:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2on0144.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.100.144) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 01 Oct 2014 18:07:15 +0000 Received: from BN1PR0301MB0625.namprd03.prod.outlook.com (25.160.170.28) by BN1PR0301MB0675.namprd03.prod.outlook.com (25.160.171.24) with Microsoft SMTP Server (TLS) id 15.0.1039.15; Wed, 1 Oct 2014 18:07:13 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com (25.160.171.13) by BN1PR0301MB0625.namprd03.prod.outlook.com (25.160.170.28) with Microsoft SMTP Server (TLS) id 15.0.1039.15; Wed, 1 Oct 2014 18:07:11 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) by BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) with mapi id 15.00.1039.011; Wed, 1 Oct 2014 18:07:10 +0000 From: "mihail.nistor@freescale.com" To: Keith Seitz , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file Date: Wed, 01 Oct 2014 18:07:00 -0000 Message-ID: <5435dace65024022b64c7f86e1e37930@BN1PR0301MB0628.namprd03.prod.outlook.com> References: <1410954786-17690-1-git-send-email-mihail.nistor@freescale.com> <542459B9.9090705@redhat.com> <23ca9e13576840e280392b69e5cc7de8@BN1PR0301MB0628.namprd03.prod.outlook.com> <7dec43bc41e044fcbba3289ca7cb2697@BN1PR0301MB0628.namprd03.prod.outlook.com> <542B0854.6050804@redhat.com> In-Reply-To: <542B0854.6050804@redhat.com> x-ms-exchange-transport-fromentityheader: Hosted x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0625;UriScan:; x-forefront-prvs: 0351D213B3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(54534003)(377424004)(13464003)(189002)(199003)(51704005)(479174003)(377454003)(24454002)(86362001)(85852003)(80022003)(97736003)(99286002)(93886004)(64706001)(10300001)(99396003)(120916001)(92566001)(21056001)(66066001)(2656002)(87936001)(46102003)(101416001)(95666004)(76576001)(74316001)(31966008)(20776003)(108616004)(19580395003)(107886001)(85306004)(19580405001)(33646002)(4396001)(54356999)(76482002)(77096002)(76176999)(107046002)(106116001)(50986999)(105586002)(106356001)(24736002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR0301MB0625;H:BN1PR0301MB0628.namprd03.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0675; X-OriginatorOrg: freescale.com X-SW-Source: 2014-10/txt/msg00017.txt.bz2 Thank you for everything. I'm looking forward to receiving the final approv= al so that the patch may be submitted. Best regards, Mihai -----Original Message----- From: Keith Seitz [mailto:keiths@redhat.com]=20 Sent: Tuesday, September 30, 2014 10:45 PM To: Nistor Mihail-MNISTOR1; gdb-patches@sourceware.org Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global = function for ASM file On 09/28/2014 09:08 AM, mihail.nistor@freescale.com wrote: > -----Original Message----- > From: Nistor Mihail-MNISTOR1 > Sent: Sunday, September 28, 2014 6:47 PM > To: Keith Seitz; gdb-patches@sourceware.org > Cc: Nistor Mihail-MNISTOR1 > Subject: RE: [PATCH v2] Bug 17394: we cannot put a break-point at a=20 > global function for ASM file > > Your changes look very well, I have one little observation regarding the = filtering condition when we need to get information from minimal symbol. > Scenario: We can mix objects that were compiled/assembled by different ve= ndors and the third party assembler provides debug information and it doesn= 't have this limitation. An application may contain more than one file that= have the same name. We cannot put a breakpoint at a function in all object= s that have the same name if an object that comes from ASM file has debug i= nfo and is linked before the objects assembled with the GNU-GAS. In the new= test case I have tried to emulate the third party assembler behavior in th= e break-asm-file1.s. > That makes sense to me. FWIW, here is a combined patch which I think a main= tainer should give a final look over. Thank you for the patch! Keith gdb/ChangeLog: 2014-09-30 Keith Seitz Mihail-Marian Nistor PR gdb/17394 * linespec.c (struct collect_minsyms): Add new member `symtab'. (add_minsym): Handle cases where info.symtab is non-NULL. (search_minsyms_for_name): Add new parameter `symtab'. Handle limiting searches to a specific symtab. (add_matching_symtabs_to_info): Search through minimal symbols for language_asm files for which no new symbols are found. gdb/testsuite/ChangeLog: 2014-09-30 Mihail-Marian Nistor PR gdb/17394 * gdb.linespec/break-asm-file.c: New file. * gdb.linespec/break-asm-file.exp: New file. * gdb.linespec/break-asm-file0.s: New file. * gdb.linespec/break-asm-file1.s: New file.