From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18504 invoked by alias); 8 Oct 2014 14:07:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18492 invoked by uid 89); 8 Oct 2014 14:07:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Oct 2014 14:07:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s98E7Uml029178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Oct 2014 10:07:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s98E7S2V021635; Wed, 8 Oct 2014 10:07:29 -0400 Message-ID: <54354520.4020307@redhat.com> Date: Wed, 08 Oct 2014 14:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Get GDBserver pid on remote target References: <543404EF.4010306@redhat.com> <1412749679-27076-1-git-send-email-yao@codesourcery.com> <1412749679-27076-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1412749679-27076-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00150.txt.bz2 On 10/08/2014 07:27 AM, Yao Qi wrote: > Hi, > We see the following fail in the real remote testing... > > (gdb) Executing on target: kill -9 29808 (timeout = 300) > spawn [open ...]^M > sh: 1: kill: No such process > > The test tries to kill gdbserver in this way: > > set server_pid [exp_pid -i [board_info target fileid]] > remote_exec target "kill -9 $server_pid" > > in native testing, we'll get the pid of spawned gdbserver, however, in > remote testing, we'll get the pid of ssh session, since we start > gdbserver on the remote target through ssh. The pid on build doesn't > exist on target. > > In this patch, we tweak server-kill.c to get the parent pid, which is > the pid of GDBserver. GDB gets it and kill GDBserver on target. > > gdb/testsuite: > > 2014-10-08 Yao Qi > > * gdb.server/server-kill.c: Include sys/types.h and unistd.h. > (main): Call getppid. > * gdb.server/server-kill.exp: Set breakpoint on line "i = 0;" > and continue to it. Read variable "server_pid". > --- > gdb/testsuite/gdb.server/server-kill.c | 10 +++++++++- > gdb/testsuite/gdb.server/server-kill.exp | 17 ++++++++++++++++- > 2 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.server/server-kill.c b/gdb/testsuite/gdb.server/server-kill.c > index 8a7c74e..8369024b 100644 > --- a/gdb/testsuite/gdb.server/server-kill.c > +++ b/gdb/testsuite/gdb.server/server-kill.c > @@ -15,10 +15,18 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > +#include > +#include > + > +int server_pid; > + > int > main (void) > { > - int i = 0; > + int i; > + > + server_pid = getppid (); > + i = 0; > > return i; > } > diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp > index b23c2b5..0f808a9 100644 > --- a/gdb/testsuite/gdb.server/server-kill.exp > +++ b/gdb/testsuite/gdb.server/server-kill.exp > @@ -33,7 +33,22 @@ gdb_test "disconnect" ".*" > > gdbserver_run "" > > -set server_pid [exp_pid -i [board_info target fileid]] > +# Continue past server_pid assignment. > +gdb_breakpoint ${srcfile}:[gdb_get_line_number "i = 0;"] > +gdb_continue_to_breakpoint "after server_pid assignment" > + > +# Get the pid of GDBServer. > +set test "p server_pid" > +gdb_test_multiple $test $test { > + -re " = ($decimal)\r\n$gdb_prompt $" { > + set server_pid $expect_out(1,string) > + pass $test > + } > + -re "$gdb_prompt $" { > + fail $test > + return -1 > + } > +} If gdb_test_multiple catches an internal error, or a timeout, this won't return, and below we'll end up using $server_pid without it being set. So please do the usual (also note "GDBserver" typo): # Get GDBserver's pid. set server_pid "" set test "p server_pid" gdb_test_multiple $test $test { -re " = ($decimal)\r\n$gdb_prompt $" { set server_pid $expect_out(1,string) pass $test } } if {$server_pid == "" } { return -1 } This is OK with that change. I think mingw doesn't have getppid; so as is this will be losing coverage there. gnulib doesn't appear to have something we could borrow, unfortunately. I think we could emulate it with NtQueryInformationProcess, but it's fine with me to leave it for another pass. Thanks, Pedro Alves