From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27816 invoked by alias); 8 Oct 2014 13:48:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27806 invoked by uid 89); 8 Oct 2014 13:48:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Oct 2014 13:48:54 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s98DmqWX005272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Oct 2014 09:48:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s98DmooB001022; Wed, 8 Oct 2014 09:48:51 -0400 Message-ID: <543540C2.7060103@redhat.com> Date: Wed, 08 Oct 2014 13:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Clean up server-kill.exp References: <543404EF.4010306@redhat.com> <1412749679-27076-1-git-send-email-yao@codesourcery.com> <1412749679-27076-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1412749679-27076-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00148.txt.bz2 On 10/08/2014 07:27 AM, Yao Qi wrote: > This patch is to remove some lines which looks unnecessary. These > lines were added when server-kill.exp was added. In the version 1, > https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test > calls runto_main and delete breakpoint on main, > > +if ![runto_main] { > + return -1 > +} > + > +# Otherwise the breakpoint at 'main' would not cause insert breakpoints during > +# first step. > +delete_breakpoints > > However, in the version 2 > https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main > is removed but delete_breakpoints is still there. AFAICS, the line of > delete_breakpoints can be removed too. > > gdb/testsuite: > > 2014-10-08 Yao Qi > > * gdb.server/server-kill.exp: Remove "delete_breakpoints". OK. Thanks, Pedro Alves