From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4285 invoked by alias); 7 Oct 2014 17:09:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4275 invoked by uid 89); 7 Oct 2014 17:09:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Oct 2014 17:09:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s97H9ASJ030915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Oct 2014 13:09:11 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s97H98NU000777; Tue, 7 Oct 2014 13:09:09 -0400 Message-ID: <54341E34.9050809@redhat.com> Date: Tue, 07 Oct 2014 17:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Ajit Kumar Agarwal , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Added cleanup data for invalid target description References: <07638ee5ff984d21a51b468a841f9dba@BN1AFFO11FD045.protection.gbl> <54340FBE.2090508@redhat.com> <6216c950de8d45809bad2b931446f6d7@BN1AFFO11FD006.protection.gbl> In-Reply-To: <6216c950de8d45809bad2b931446f6d7@BN1AFFO11FD006.protection.gbl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00121.txt.bz2 On 10/07/2014 05:36 PM, Ajit Kumar Agarwal wrote: > > > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Tuesday, October 07, 2014 9:37 PM > To: Ajit Kumar Agarwal; gdb-patches@sourceware.org > Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Added cleanup data for invalid target description > > On 10/07/2014 11:16 AM, Ajit Kumar Agarwal wrote: >> >> From 00f2692d10e0254366471095516d657693aeff42 Mon Sep 17 00:00:00 2001 >> From: Ajit Kumar Agarwal >> Date: Tue, 7 Oct 2014 15:06:08 +0530 >> Subject: [PATCH] [Patch, microblaze]: Added cleanup data for invalid target description. > >>> s/Added/Add/. But even better would be saying what this actually intends to do, which is "reject". Note the [PATCH] tag usually end ups stripped when >>the commit is imported into git, but the redundant [Patch, ...] seems like something you added manually, and is unnecessary. > > Thanks for the suggestion. >> >> Cleanup the tdesc data if the target description check is invalid. >> >> 2014-10-07 Ajit Agarwal >> >> * microblaze-tdep.c (microblaze_gdbarch_init): Use of >> tdesc_data_cleanup. > > So, I'd write: > > ~~~ >>> [PATCH] Microblaze: Reject invalid target descriptions > >>> We currently validate the target description, but then forget to reject it if found invalid. > >>> gdb/ >>> 2014-10-07 Ajit Agarwal > >>> * microblaze-tdep.c (microblaze_gdbarch_init): If the description >>> isn't valid, release the tdesc arch data and return NULL. > ~~~ > > I will make this Change. Thanks for suggestion. > >>> But, you didn't state how you tested this, which should be part of the commit log too. > > I have tested the Microblaze Design with and without stack -protect registers. The gdb command "info registers" displayed the register correctly. If stack protect designs is not selected only core registers are displayed. When the stack-protect register is selected in the design, the core registers along with stack-protect registers are displayed. Please remember to always state this in the commit/submit log. I've now added an explicit bullet item for that to the contribution checklist. > >>> Did you make sure incorrect descriptions are rejected and GDB warns about them? > > We don't have the invalid Microblaze design with which I can test gdb warning and cleaning up the tdesc data. Sure you do. Just hack your target or gdbserver to send a bogus description. Thanks, Pedro Alves