Re: [IRIX] eliminate deprecated_insert_raw_breakpoint uses

Joel Brobecker
2014-09-12T20:23:45Z

> Thanks Joel. I've addressed that issue by marking the breakpoints
> as disp_del_at_next_stop instead of deleting them immediately.
>
> Locally, I added a call to remove_solib_event_breakpoints_at_next_stop
> to solib-svr4.c:svr4_handle_solib_event, to check that the breakpoint
> does indeed end up removed, and that we don't crash. Adding a
> call to remove_solib_event_breakpoints instead would crash in the
> same way you saw on IRIX with the previous version of this patch.
>
> I avoided exposing insert_breakpoint_locations out of breakpoint.c by
> adding a new create_and_insert_solib_event_breakpoint function
> that is like create_solib_event_breakpoint but tries to insert the
> breakpoint immediately.
>
> I figure that if someone wants to keep IRIX alive (either now, by
> bringing it back from git), this will be a better base to start
> from.
>
> So in interest of not having to wait for IRIX to be dropped,
> I've gone ahead and pushed the patch below.

I've just rebuilt GDB again, and I can confirm that the problem
is fixed. After starting a program, I can still see the same
list of shared libraries as before your change.

Cheers!

--
Joel