From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100541 invoked by alias); 21 Jun 2017 17:01:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100474 invoked by uid 89); 21 Jun 2017 17:01:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=investigated, progressive, simark, Share X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 17:01:11 +0000 Received: by simark.ca (Postfix, from userid 33) id A39A11E4E8; Wed, 21 Jun 2017 13:01:09 -0400 (EDT) To: Sergio Durigan Junior Subject: Re: [PATCH v7 3/4] Share fork_inferior et al with gdbserver X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 21 Jun 2017 17:01:00 -0000 From: Simon Marchi Cc: GDB Patches , Pedro Alves , Tristan Gingold In-Reply-To: <20170604221803.17649-4-sergiodj@redhat.com> References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170604221803.17649-1-sergiodj@redhat.com> <20170604221803.17649-4-sergiodj@redhat.com> Message-ID: <542fdddc3c72c23a0e68b2c912d52746@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00597.txt.bz2 On 2017-06-05 00:18, Sergio Durigan Junior wrote: > This is the most important (and the biggest, sorry) patch of the > series. It moves fork_inferior from gdb/fork-child.c to > common/common-fork-child.c and makes all the necessary adjustments to > both GDB and gdbserver to make sure everything works OK. > > There is no "most important change" with this patch; all changes are > made in a progressive way, making sure that gdbserver had the > necessary features while not breaking GDB at the same time. > > I decided to go ahead and implement a partial support for starting the > inferior with a shell on gdbserver, although the full feature comes in > the next patch. The user won't have the option to disable the > startup-with-shell, and also won't be able to change which shell > gdbserver will use (other than setting the $SHELL environment > variable, that is). > > Everything is working as expected, and no regressions were present > during the tests. I just started to play with GDB on macOS, and it seems currently broken, a bisect pointed me to this commit (2090129c36c7e582943b7d300968d19b46160d84). When trying to run/start, I get this: Temporary breakpoint 1 at 0x100000fb6: file /Users/simark/test.c, line 2. Starting program: /Users/simark/test /Users/simark/src/binutils-gdb/gdb/darwin-nat.c:383: internal-error: void darwin_check_new_threads(struct inferior *): Assertion `tp' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) I haven't investigated yet, but I thought I'd share the information in case somebody is interested . I am CCing Tristan because he's the last person who made fixes to keep the macOS support somewhat working (thanks!). If you could at least tell if you get the same error, it would be helpful. Thanks, Simon