From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31759 invoked by alias); 2 Oct 2014 17:55:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31745 invoked by uid 89); 2 Oct 2014 17:55:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Oct 2014 17:55:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s92HtkZ1004767 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 2 Oct 2014 13:55:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s92Hti98029187; Thu, 2 Oct 2014 13:55:45 -0400 Message-ID: <542D91A0.8010205@redhat.com> Date: Thu, 02 Oct 2014 17:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain References: <1411691982-10744-1-git-send-email-palves@redhat.com> <1411691982-10744-4-git-send-email-palves@redhat.com> <877g0nvt11.fsf@codesourcery.com> In-Reply-To: <877g0nvt11.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00039.txt.bz2 On 09/29/2014 07:29 AM, Yao Qi wrote: > Pedro Alves writes: > >> This patch makes single-step breakpoints "real" breakpoints on the >> global location list. > > We also need to skip adjusting breakpoint address > (in adjust_breakpoint_address) for bp_single_step, otherwise, > arm-linux-gnueabi gdb has a trouble on stepping through IT block, as > gdb.arch/thumb2-it.exp tested. Thanks Yao, makes sense. v2 will do this. Thanks, Pedro Alves