From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27753 invoked by alias); 30 Sep 2014 13:15:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27742 invoked by uid 89); 30 Sep 2014 13:15:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Sep 2014 13:15:07 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8UDF2uS017992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Sep 2014 09:15:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8UDF0eF013173; Tue, 30 Sep 2014 09:15:00 -0400 Message-ID: <542AACD3.8070505@redhat.com> Date: Tue, 30 Sep 2014 13:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain References: <1411691982-10744-1-git-send-email-palves@redhat.com> <1411691982-10744-4-git-send-email-palves@redhat.com> <87k34ovsc1.fsf@codesourcery.com> <542AA998.2090604@redhat.com> In-Reply-To: <542AA998.2090604@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00888.txt.bz2 On 09/30/2014 02:01 PM, Pedro Alves wrote: > On 09/28/2014 01:32 PM, Yao Qi wrote: >> Pedro Alves writes: >> >>> @@ -15496,22 +15466,9 @@ single_step_breakpoints_inserted (void) >>> void >>> remove_single_step_breakpoints (void) >>> { >>> - gdb_assert (single_step_breakpoints[0] != NULL); >>> + gdb_assert (single_step_breakpoints != NULL); >>> >>> - /* See insert_single_step_breakpoint for more about this deprecated >>> - call. */ >>> - deprecated_remove_raw_breakpoint (single_step_gdbarch[0], >>> - single_step_breakpoints[0]); >>> - single_step_gdbarch[0] = NULL; >>> - single_step_breakpoints[0] = NULL; >>> - >>> - if (single_step_breakpoints[1] != NULL) >>> - { >>> - deprecated_remove_raw_breakpoint (single_step_gdbarch[1], >>> - single_step_breakpoints[1]); >>> - single_step_gdbarch[1] = NULL; >>> - single_step_breakpoints[1] = NULL; >>> - } >>> + delete_breakpoint (single_step_breakpoints); >> >> We need to set single_step_breakpoints back to NULL. This causes many >> fails for arm-linux-gnueabi target, as I tested. > > Thanks Yao. > > I'll try to figure out why I didn't see that in my testing... Ah, I failed to test this revision of the patch alone on top of the sss-on-x86 series. A later patch in the series removes this function, and instead deletes the sss breakpoint through this: /* Delete the breakpoint pointed at by BP_P, if there's one. */ static void delete_thread_breakpoint (struct breakpoint **bp_p) { if (*bp_p != NULL) { delete_breakpoint (*bp_p); *bp_p = NULL; } } which clears the pointer. I'll rebase this on top of the x86-on-sss series instead of the other way around, and re-test it. It's a pain, but it'll be my penance... Thanks, Pedro Alves