From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5021 invoked by alias); 30 Sep 2014 10:56:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5003 invoked by uid 89); 30 Sep 2014 10:56:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Sep 2014 10:56:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8UAuX8K013757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Sep 2014 06:56:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8UAuLfU026456; Tue, 30 Sep 2014 06:56:22 -0400 Message-ID: <542A8C54.1070005@redhat.com> Date: Tue, 30 Sep 2014 10:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Breazeal, Don" , gdb-patches@sourceware.org Subject: Re: [PATCH 01/16 v2] Refactor native follow-fork References: <1407434395-19089-1-git-send-email-donb@codesourcery.com> <1408580964-27916-2-git-send-email-donb@codesourcery.com> <5409C69F.8030906@redhat.com> <540E41C5.2000600@codesourcery.com> <540EDFFE.4090703@redhat.com> <54132443.5060602@codesourcery.com> <5425ACBF.7080800@redhat.com> <54299FF8.7000205@codesourcery.com> In-Reply-To: <54299FF8.7000205@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00883.txt.bz2 On 09/29/2014 07:07 PM, Breazeal, Don wrote: > The patch is standalone and I believe it has value independent > of the rest of the series. Yes, agreed. > OK to push? Yes, please push. > +/* Handle changes to the inferior list based on the type of fork, > + which process is being followed, and whether the other process > + should be detached. On entry inferior_ptid must be the ptid of > + the fork parent. At return inferior_ptid is the ptid of the > + followed inferior. */ > + > +int 'static int' here too. Consider putting the function above its caller thus avoiding the need for the other declaration at the top. > +follow_fork_inferior (int follow_child, int detach_fork) > +{ Thanks, Pedro Alves