From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10663 invoked by alias); 25 Sep 2014 21:13:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10650 invoked by uid 89); 25 Sep 2014 21:13:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Sep 2014 21:13:33 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8PLDWO4003092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 25 Sep 2014 17:13:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8PLDT6q013855; Thu, 25 Sep 2014 17:13:30 -0400 Message-ID: <54248579.8030606@redhat.com> Date: Thu, 25 Sep 2014 21:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches , Gary Benson Subject: Re: [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes References: <1411581801-19126-1-git-send-email-sergiodj@redhat.com> <5423F08B.1040409@redhat.com> <87bnq3h1gf.fsf_-_@redhat.com> In-Reply-To: <87bnq3h1gf.fsf_-_@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00747.txt.bz2 On 09/25/2014 09:47 PM, Sergio Durigan Junior wrote: > Thanks for the review. > > On Thursday, September 25 2014, Pedro Alves wrote: > >> Well, AFAICS, upstream GDB still supports F17's probes. See >> svr4_create_solib_event_breakpoints: >> >> memset (probes, 0, sizeof (probes)); >> for (i = 0; i < NUM_PROBES; i++) >> { >> const char *name = probe_info[i].name; >> struct probe *p; >> char buf[32]; >> >> /* Fedora 17 and Red Hat Enterprise Linux 6.2-6.4 >> shipped with an early version of the probes code in >> which the probes' names were prefixed with "rtld_" >> and the "map_failed" probe did not exist. The >> locations of the probes are otherwise the same, so >> we check for probes with prefixed names if probes >> with unprefixed names are not present. */ >> if (with_prefix) >> { >> xsnprintf (buf, sizeof (buf), "rtld_%s", name); >> name = buf; >> } >> >> probes[i] > > Indeed it does, thanks for catching this. > >> So it seems to me the test should cope with both variants. > > Or maybe we should simplify this code and remove this support. > > Really, Fedora 17 was EOL'ed more than 1 year ago: > > > > And we are already on Fedora 20, moving towards Fedora 21. Also, this > code was needed because a patch present in Fedora 17's glibc, so I think > it is fair to leave this to be handled by Fedora GDB if needed (but it > won't be, because the upstream glibc patches already made into Fedora > too). There's RHEL (at least, per the comment) 6.4 too, which isn't EOL'ed, though. It's reasonable to expect that people may still want to build/test upstream gdb on those? Thanks, Pedro Alves