Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Paul_Koning@dell.com
Cc: gdb-patches@sourceware.org, dje@google.com
Subject: Re: Why do functions objfpy_new and pspy_new exist?
Date: Thu, 25 Sep 2014 21:29:00 -0000	[thread overview]
Message-ID: <54248505.7030809@redhat.com> (raw)
In-Reply-To: <E3798679-04DA-48B8-8E53-5296A54A3528@dell.com>

On 25/09/14 16:18, Paul_Koning@dell.com wrote:
>
> On Sep 25, 2014, at 6:09 AM, Phil Muldoon <pmuldoon@redhat.com> wrote:
>
>> On 24/09/14 22:38, Doug Evans wrote:
>>> Hi.
>>>
>>> Normally, python wrappers of gdb objects are created with a
>>> foo_to_foo_object function.
>>> E.g., objfile_to_objfile_object and pspace_to_pspace_object.
>>>
>>> So why do objfpy_new and pspy_new exist?
>>> [defined in py-objfile.c and py-progspace.c respectively]
>>>
>>> IOW, when would one ever usefully do something with
>>> foo_objfile = gdb.Objfile()
>>> or
>>> foo_pspace = gdb.Progspace()
>>
>> I can't think of a reason.  But someone else might.  Anyway the point
>> is moot (unfortunately) as we have an API promise, so they get to
>> stay.  Forever.
>
> I would usually agree, but I would make an exception if the API function in question does not produce anything that can be used for any plausible purpose.  That may be the case here.


I really don't disagree with you Paul.  But we have to prove
plausible, and perhaps wait until someone turns up and says "oh I have
this plausible scenario".  Perhaps a patch to gdb-patches and a
suitable wait is OK, (though I am not sure GDB Python users read that
list).  It is, trust me, a frequent frustration for me to add
yet-another-keyword-while-preserving-original-behavior, especially
with the Python 2.x and 3.x as well.  It is, I think, becoming
impossible to manage.

I don't have an objection beyond does this break the API promise.
That's all I care about.  I did not make that promise -- these
decisions were made before my time.  But I think we should uphold it.
Maybe if GDB future releases requires only Python 3.x in future we can
amend that.

Cheers,

Phil


  reply	other threads:[~2014-09-25 21:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 21:38 Doug Evans
2014-09-25 10:09 ` Phil Muldoon
2014-09-25 15:18   ` Paul_Koning
2014-09-25 21:29     ` Phil Muldoon [this message]
2014-09-25 22:07       ` Doug Evans
2014-10-01 18:10         ` Phil Muldoon
2014-10-02 22:11         ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54248505.7030809@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=Paul_Koning@dell.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox