From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21031 invoked by alias); 25 Sep 2014 15:38:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21016 invoked by uid 89); 25 Sep 2014 15:38:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Sep 2014 15:38:14 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8PFc9YE014655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Sep 2014 11:38:10 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8PFc7uS027473; Thu, 25 Sep 2014 11:38:08 -0400 Message-ID: <542436DE.4030005@redhat.com> Date: Thu, 25 Sep 2014 15:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Skip dlopen-libpthread.exp in cross testing References: <1411631571-30769-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1411631571-30769-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00739.txt.bz2 On 09/25/2014 08:52 AM, Yao Qi wrote: > performed. Then I check the callers of build_executable_own_libs, > and they are all skipped if isnative is false. It is reasonable to do > the same in dlopen-libpthread.exp too. Agreed. I think we should put an "error" call in build_executable_own_libs too, so that whoever adds the next test that uses this doesn't end up forgetting the same thing. Thanks, Pedro Alves