Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"

Simon Marchi
2014-09-26T14:37:03Z

On 2014-09-25 03:13 PM, Doug Evans wrote:
> On Thu, Sep 25, 2014 at 8:44 AM, Simon Marchi <simon.marchi@ericsson.com> wrote:
>> On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote:
>>> On Wednesday, September 24 2014, Doug Evans wrote:
>>>
>>>> IOW, how about move the call to prune_program_spaces to whatever
>>>> caller wants it.
>>>
>>> As a note, after I commented on the patch, I noticed that the "prune"
>>> argument may be unecessary indeed (and the "prunning" logic"), because
>>> we are not prunning anything anymore.
>>>
>>> Anyway, I just wanted to say that I agree with removing this part of the
>>> code, and moving it to more suitable parts.
>>
>> Fine with me. Here is the updated patch, much simpler now.
>>
>> gdb/Changelog:
>>
>> * progspace.c (print_program_space): Don't prune program spaces
>> before printing them.
>
> LGTM
>
> In the commit log I would add a note that this was removed so that the
> print routine didn't have (unwanted) side-effects.
>
> Thanks.

Pushed, thanks!