From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116028-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8389 invoked by alias); 18 Sep 2014 14:17:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8375 invoked by uid 89); 18 Sep 2014 14:17:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Sep 2014 14:17:02 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8IEGqfX009749	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 18 Sep 2014 10:16:52 -0400
Received: from localhost.localdomain (ovpn-112-76.ams2.redhat.com [10.36.112.76])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8IEGoBF032039;	Thu, 18 Sep 2014 10:16:51 -0400
Message-ID: <541AE951.6080404@redhat.com>
Date: Thu, 18 Sep 2014 14:17:00 -0000
From: Phil Muldoon <pmuldoon@redhat.com>
MIME-Version: 1.0
To: Doug Evans <dje@google.com>, Pedro Alves <palves@redhat.com>
CC: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [PATCH] New "producer" attribute for gdb.Symtab objects
References: <yjt2ppevf8il.fsf@ruffy.mtv.corp.google.com>	<5418D665.5090309@redhat.com> <21530.11079.11868.273521@ruffy2.mtv.corp.google.com>
In-Reply-To: <21530.11079.11868.273521@ruffy2.mtv.corp.google.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00619.txt.bz2

On 18/09/14 01:45, Doug Evans wrote:
> Pedro Alves writes:
>  > On 09/17/2014 12:30 AM, Doug Evans wrote:
>  > > +# We can't do much to test the producer string (compiler name+version).
>  >
>  > Sounds like a job for the testsuite's dwarf compiler.
>  >
>  > > +# But we do have support for knowing whether gcc was used, so we can at
>  > > +# least use that.
>  > > +if { $gcc_compiled } {
>  > > +    set producer_regexp "GNU.*"
>  > > +} else {
>  > > +    set producer_regexp ""
>  > > +}
>
> Indeed.

I looked at the patch and it seems just fine.  Is it just GCC that
inserts a producer?

Cheers

Phil