Re: [PATCH] New "producer" attribute for gdb.Symtab objects

[Pedro Alves <palves@redhat.com>]

On 09/18/2014 01:45 AM, Doug Evans wrote:
> Pedro Alves writes:
>  > On 09/17/2014 12:30 AM, Doug Evans wrote:
>  > > +# We can't do much to test the producer string (compiler name+version).
>  > 
>  > Sounds like a job for the testsuite's dwarf compiler.
> 
> Indeed.

Nice, this looks good to me.  Thanks.

> +        } {
> +	    declare_labels integer_label
> +
> +            integer_label: DW_TAG_base_type {
> +                {DW_AT_byte_size 4 DW_FORM_sdata}
> +                {DW_AT_encoding @DW_ATE_signed}
> +                {DW_AT_name integer}
> +            }
> +

Something odd with indentation here (and likewise
in the other CU).  Looks like tabs vs spaces.

> +	    DW_TAG_variable {
> +		{DW_AT_name with_producer}
> +		{DW_AT_type :$integer_label}
> +		{DW_AT_external 1 flag}
> +		{DW_AT_const_value 42 DW_FORM_sdata}
> +	    }

Thanks,
Pedro Alves