From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
gdb-patches@sourceware.org
Subject: Re: [pushed] Add test to make sure GDB knows which "kind" of watchpoint the target has
Date: Tue, 16 Sep 2014 13:27:00 -0000 [thread overview]
Message-ID: <54183ACC.7060001@redhat.com> (raw)
In-Reply-To: <000601cfd1b1$718bd600$54a38200$@muller@ics-cnrs.unistra.fr>
On 09/16/2014 02:23 PM, Pierre Muller wrote:
> Hi Pedro,
>
> I think there is a typo inside this:
>> + set sw_watch_pc [get_pc "get sw watchpoint PC"]
>> +
>> + delete_breakpoints
>> +
>> + # Allow hardware watchpoints again.
>> + gdb_test_no_output "set can-use-hw-watchpoints 1"
>> +
>> + gdb_test "watch global" \
>> + "Hardware watchpoint .*: global" \
>> + "set hardware watchpoint on global variable"
>> +
>> + gdb_test "continue" \
>> + "Hardware watchpoint .*: global.*Old value = 1.*New value =
>> 2.*set_global \\(val=2\\).*$srcfile.*" \
>> + "hardware watchpoint triggers"
>> +
>> + set hw_watch_pc [get_pc "get hw watchpoint PC"]
>> +
>> + gdb_assert {$sw_watch_pc == $sw_watch_pc} "hw watchpoint stops at
>> right instruction"
> Shouldn't this be
> {$sw_watch_pc == $hw_watch_pc}?
Argh... Right you are.
Many thanks,
Pedro Alves
prev parent reply other threads:[~2014-09-16 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 13:18 Pedro Alves
2014-09-16 13:23 ` Pierre Muller
2014-09-16 13:27 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54183ACC.7060001@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox