From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5808 invoked by alias); 12 Sep 2014 21:44:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5793 invoked by uid 89); 12 Sep 2014 21:44:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 21:44:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CLigNh024920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Sep 2014 17:44:42 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8CLidoY006076; Fri, 12 Sep 2014 17:44:40 -0400 Message-ID: <54136947.4020003@redhat.com> Date: Fri, 12 Sep 2014 21:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Joel Brobecker CC: Edjunior Barbosa Machado , gdb-patches@sourceware.org, Ulrich Weigand , Sergio Durigan Junior Subject: Re: [PATCH] after gdb_run_cmd, gdb_expect -> gdb_test_multiple/gdb_test References: <1410490007-19756-1-git-send-email-emachado@linux.vnet.ibm.com> <5412C3F0.9000703@redhat.com> <20140912130051.GA4871@adacore.com> <5412F714.3040500@redhat.com> <20140912135012.GC4871@adacore.com> <54130176.1070208@gmail.com> <541310E1.5000806@redhat.com> <20140912171051.GF4871@adacore.com> In-Reply-To: <20140912171051.GF4871@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00469.txt.bz2 On 09/12/2014 06:10 PM, Joel Brobecker wrote: >>> I'm writing a test that converts all gdb_run_cmd -> gdb_expect >>> cases to avoid this from spreading further. >> >> Patch pasted below. > > Thanks Pedro. I started reviewing it, and then switch to scanner-mode > half way through. It looks great! Thanks Joel. Now pushed. >> In a2-run.exp I converted one vxworks path, but left the others >> in place... I'm tempted to nuke most of that vxworks stuff >> out of the testsuite. Does anyone still care about it? > > I suspect no one does. I even suspect that no one even cares > about whatever old version of vxworks is supported by GDB. > IIRC, that code pre-dates my involvement in the GDB project, > which started around 2001. Oh, I notice that the vxworks support the testsuite is caring about must be for a "target vxworks_or_something", not "target remote", because we have in gdb/testsuite/gdb.base/default.exp: } elseif [istarget "*-*-vxworks*"] then { gdb_test "set args" ".*" "" gdb_test "r" "Starting program: .* You must specify a function name to run, and arguments if any"\ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ "run \"r\" abbreviation" gdb_test "set args main" ".*" "" And indeed, that target has been removed 10 years ago already ... commit e84ecc995d6a5e4e9114d3cea61717b8a573afb6 Author: Andrew Cagney AuthorDate: Sat Nov 13 23:10:02 2004 +0000 2004-11-13 Andrew Cagney * configure.tgt: Delete i[34567]86-*-vxworks*, m68*-netx-*, m68*-*-vxworks*, mips*-*-vxworks*, powerpc-*-vxworks*, and sparc-*-vxworks*. * NEWS: Mention that vxworks was deleted. Which had: -static void -vx_create_inferior (char *exec_file, char *args, char **env, int from_tty) -{ - enum clnt_stat status; - arg_array passArgs; - TASK_START taskStart; - - memset ((char *) &passArgs, '\0', sizeof (passArgs)); - memset ((char *) &taskStart, '\0', sizeof (taskStart)); - - /* parse arguments, put them in passArgs */ - - parse_args (args, &passArgs); - - if (passArgs.arg_array_len == 0) - error ("You must specify a function name to run, and arguments if any"); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ So I'm going to delete all that cruft. OOC, how does one debug Ravenscar then? Does that sit on top of target remote ? Thanks, Pedro Alves