From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11705 invoked by alias); 12 Sep 2014 12:00:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11679 invoked by uid 89); 12 Sep 2014 12:00:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 12:00:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CBxwsb006707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Sep 2014 07:59:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8CBxuRT032207; Fri, 12 Sep 2014 07:59:57 -0400 Message-ID: <5412E03C.1070402@redhat.com> Date: Fri, 12 Sep 2014 12:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Doug Evans Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-4-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-4-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00395.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > +/* See target/target.h. */ > + > +void > +target_stop_ptid (ptid_t ptid) > +{ > + struct target_waitstatus status; > + int was_non_stop = non_stop; > + > + non_stop = 1; > + target_stop (ptid); > + > + memset (&status, 0, sizeof (status)); > + target_wait (ptid, &status, 0); > + > + non_stop = was_non_stop; > +} One thing that was bugging me was that given that the names of target_stop and target_stop_ptid are so similar and that they have the same signature is ripe for confusion. I just now noticed the elephant in the room -- target_stop is asynchronous, doesn't wait for a stop, while and target_stop_ptid is synchronous. Would you mind renaming this to target_stop_wait or some such? And then add an explicit "and wait for it to stop" or some such to the function's description. Thanks, Pedro Alves