From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30729 invoked by alias); 11 Sep 2014 19:33:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30720 invoked by uid 89); 11 Sep 2014 19:33:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Sep 2014 19:33:04 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 9C.1A.25146.7F0A1145; Thu, 11 Sep 2014 15:17:43 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 11 Sep 2014 15:33:01 -0400 Message-ID: <5411F8EC.9080804@ericsson.com> Date: Thu, 11 Sep 2014 19:33:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: , Subject: Re: [PATCH v3] Introduce remote_target_is_gdbserver References: <1410447276-21821-1-git-send-email-simon.marchi@ericsson.com> <5411C969.9050107@codesourcery.com> In-Reply-To: <5411C969.9050107@codesourcery.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00374.txt.bz2 > Just a thought but... is there a specific reason we need to check for > gdbserver explicitly as opposed to checking for a remote debugging stub > feature? > > It sounds more appropriate to leave remote stub-based testing as generic > as possible, in which case "is_gdbserver" wouldn't be needed. Good point, but I'd rather not address this in the current patch. I don't want to change the test itself, but just make the check available to other tests. Ultimately, I want to use it in this patch [1] where I really want to check for GDBserver. I want to KFAIL a test only when using gdbserver, due to a known bug in gdbserver. [1] https://sourceware.org/ml/gdb-patches/2014-09/msg00148.html