From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10550 invoked by alias); 11 Sep 2014 14:47:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10530 invoked by uid 89); 11 Sep 2014 14:47:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Sep 2014 14:47:55 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 11.22.05330.F8061145; Thu, 11 Sep 2014 10:42:55 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 11 Sep 2014 10:47:52 -0400 Message-ID: <5411B618.5060800@ericsson.com> Date: Thu, 11 Sep 2014 14:47:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Subject: Re: [PATCH v2] Introduce remote_target_is_gdbserver References: <1409948495-13599-1-git-send-email-simon.marchi@ericsson.com> <87k35h3asl.fsf@redhat.com> In-Reply-To: <87k35h3asl.fsf@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00357.txt.bz2 On 14-09-05 07:30 PM, Sergio Durigan Junior wrote: > On Friday, September 05 2014, Simon Marchi wrote: > >> Oops, I had some unstaged changes when I sent this patch, so here is >> an updated one with those changes. Sorry for the noise. >> >> This patch introduces a function in gdbserver-support.exp to find out >> whether the current target is GDBserver. >> >> The code was inspired from gdb.trace/qtor.exp, so it replaces the code >> there by a call to the new function. > > Hi Simon, > > Thanks for the patch. A few comments. > >> gdb/testsuite/ChangeLog: >> >> * lib/gdbserver-support.exp (remote_target_is_gdbserver): New >> fonction. > > Typo: fonction. > > You also forgot to mention the change to gdb.trace/qtro.exp. > >> --- >> gdb/testsuite/gdb.trace/qtro.exp | 14 +------------- >> gdb/testsuite/lib/gdbserver-support.exp | 23 +++++++++++++++++++++++ >> 2 files changed, 24 insertions(+), 13 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp >> index 22b5051..95b6b85 100644 >> --- a/gdb/testsuite/gdb.trace/qtro.exp >> +++ b/gdb/testsuite/gdb.trace/qtro.exp >> @@ -98,19 +98,7 @@ if { $traceframe_info_supported == -1 } { >> } >> >> # Check whether we're testing with our own GDBserver. >> -set is_gdbserver -1 >> -set test "probe for GDBserver" >> -gdb_test_multiple "monitor help" $test { >> - -re "The following monitor commands are supported.*debug-hw-points.*remote-debug.*GDBserver.*$gdb_prompt $" { >> - set is_gdbserver 1 >> - pass $test >> - } >> - -re "$gdb_prompt $" { >> - set is_gdbserver 0 >> - pass $test >> - } >> -} >> -if { $is_gdbserver == -1 } { >> +if ![remote_target_is_gdbserver] { > > I know it's just a matter of style, but I'd prefer if you kept the > surrounding brackets in the condition: > > if { ![remote_target_is_gdbserver] } { > ... > >> return -1 >> } >> >> diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp >> index 8c91e28..300c3db 100644 >> --- a/gdb/testsuite/lib/gdbserver-support.exp >> +++ b/gdb/testsuite/lib/gdbserver-support.exp >> @@ -419,3 +419,26 @@ proc mi_gdbserver_start_multi { } { >> >> return [mi_gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport] >> } >> + >> +# Return true if the current remote target is an instance of gdbserver. >> + >> +proc remote_target_is_gdbserver { } { >> + global gdb_prompt >> + >> + set is_gdbserver 0 >> + set test "Probing for GDBserver" >> + >> + gdb_test_multiple "monitor help" $test { >> + -re "The following monitor commands are supported.*Quit GDBserver.*$gdb_prompt $" { >> + pass $test >> + set is_gdbserver 1 >> + } >> + -re "$gdb_prompt $" { >> + pass $test >> + } >> + default { >> + pass $test >> + } > > Do we really need these "pass"? I'd rather we don't put it, and by > looking at lib/gdb.exp I see many tests also don't use it. I thought so, but apparently no. I thought that each gdb_test_multiple had to be matched with one pass or fail. >> + } >> + return $is_gdbserver >> +} > > Otherwise, looks good to me (this is not an approval). > > Cheers, Thanks, Sending v2 now.