From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9591 invoked by alias); 10 Sep 2014 13:29:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9582 invoked by uid 89); 10 Sep 2014 13:29:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 13:29:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8ADTXVi002824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 09:29:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8ADTWV5026731; Wed, 10 Sep 2014 09:29:32 -0400 Message-ID: <5410523B.8020305@redhat.com> Date: Wed, 10 Sep 2014 13:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Doug Evans Subject: Re: [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-10-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-10-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00304.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > > -static unsigned int debug_linux_nat; > +unsigned int debug_linux_nat; > + > +#define debug_linux_waitpid debug_linux_nat > #endif > +extern int debug_linux_waitpid; > The dangers of extern... This ends up undefined code, as the variable is defined as signed, and then declared here as signed. Sorry, but now that I see it, IMO the end up resulting code doesn't really look better than what we already have. :-/ We end up with #ifdef GDBSERVER anyway, so might be best to either leave this be until we come up with a complete solution. Thanks, Pedro Alves