From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20867 invoked by alias); 10 Sep 2014 13:11:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20858 invoked by uid 89); 10 Sep 2014 13:11:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 13:11:19 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8ADBHSZ002958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 09:11:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8ADBFTu009307; Wed, 10 Sep 2014 09:11:15 -0400 Message-ID: <54104DF2.7060704@redhat.com> Date: Wed, 10 Sep 2014 13:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Pedro Alves , Doug Evans Subject: Re: [PATCH 6/9 v7] Include common-defs.h instead of defs.h/server.h in shared code References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-7-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-7-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00299.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > This commit makes 19 of the 22 shared .c files in common, nat and > target include common-defs.h instead of defs.h/server.h. The > remaining three files need slight extra work and are dealt with > in separate commits. > > This patch is unchanged from the version I posted August 1: > https://sourceware.org/ml/gdb-patches/2014-08/msg00012.html > > gdb/ChangeLog: > > * common/agent.c: Include common-defs.h. > Don't include defs.h or server.h. > * common/buffer.c: Likewise. > * common/common-debug.c: Likewise. > * common/common-utils.c: Likewise. > * common/errors.c: Likewise. > * common/filestuff.c: Likewise. > * common/format.c: Likewise. > * common/gdb_vecs.c: Likewise. > * common/print-utils.c: Likewise. > * common/ptid.c: Likewise. > * common/rsp-low.c: Likewise. > * common/signals.c: Likewise. > * common/vec.c: Likewise. > * common/xml-utils.c: Likewise. > * nat/linux-osdata.c: Likewise. > * nat/linux-procfs.c: Likewise. > * nat/linux-ptrace.c: Likewise. > * nat/mips-linux-watch.c: Likewise. > * target/waitstatus.c: Likewise. Looks good to me. Thanks, Pedro Alves