From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9479 invoked by alias); 10 Sep 2014 11:59:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9469 invoked by uid 89); 10 Sep 2014 11:59:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 11:59:26 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8ABxOid030680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 07:59:24 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8ABxMcZ025495; Wed, 10 Sep 2014 07:59:23 -0400 Message-ID: <54103D1A.5080302@redhat.com> Date: Wed, 10 Sep 2014 11:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Doug Evans Subject: Re: [PATCH 4/9 v7] Introduce target/symbol.h References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-5-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-5-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00293.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > This introduces target/symbol.h. This file declares a function that > the shared code can use and that the clients must implement. It also > changes some shared code to use these functions. > > This patch differs from the version I posted on August 1 > (https://sourceware.org/ml/gdb-patches/2014-08/msg00013.html) in that > the new function has been renamed as find_minimal_symbol_address and > that it lives in minsyms.c for GDB and a new file symbol.c for > gdbserver rather than in target.c for both. > > gdb/ChangeLog: > > * target/symbol.h: New file. > * Makefile.in (HFILES_NO_SRCDIR): Add target/symbol.h. > * target.h: Include target/symbol.h. > * minsyms.c (find_minimal_symbol_address): New function. > * common/agent.c: Include target/symbol.h. > [!GDBSERVER]: Don't include objfiles.h. > (agent_look_up_symbols): Use find_minimal_symbol_address. Thanks. Though for the same reason in the old version calling this new method target_foo looked wrong, because this is not interacting with the target vector abstraction (it looks like something for a client vector instead), I don't think this belongs in target/ at all. I think it should go in common/ instead for now. Related, this: > * target.h: Include target/symbol.h. looks wrong to me too, and it isn't clear to me why you needed it. Thanks, Pedro Alves