From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27612 invoked by alias); 10 Sep 2014 10:39:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27602 invoked by uid 89); 10 Sep 2014 10:39:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 10:39:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAdjAH032749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 06:39:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAdhi5012553; Wed, 10 Sep 2014 06:39:44 -0400 Message-ID: <54102A6F.1030405@redhat.com> Date: Wed, 10 Sep 2014 10:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-4-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-4-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00285.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > This commit introduces two new functions to stop and restart target > processes that shared code can use and that clients must implement. > It also changes some shared code to use these functions. > > The changes in this patch replace the target_stop, target_wait > and target_resume parts of this patch I posted on August 1: > https://sourceware.org/ml/gdb-patches/2014-08/msg00014.html > The remainder of that patch is in patch 2 of this series. > > gdb/ChangeLog: > > * target/target.h (target_stop_ptid, target_continue_ptid): > Declare. > * target.c (target_stop_ptid, target_continue_ptid): New > functions. > * common/agent.c [!GDBSERVER]: Don't include infrun.h. > (agent_run_command): Always use target_stop_ptid and > target_continue_ptid. > > gdb/gdbserver/ChangeLog: > > * target.c (target_stop_ptid, target_continue_ptid): New > functions. OK, with ... > +/* Make target stop in a continuable fashion. (For instance, under > + Unix, this should act like SIGSTOP). This function must be > + provided by the client. This function is normally used by GUIs > + to implement a stop button. */ ... Please drop the last sentence referring to GUIs. > + > +extern void target_stop_ptid (ptid_t ptid); Thanks, Pedro Alves