From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8089 invoked by alias); 10 Sep 2014 10:17:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8079 invoked by uid 89); 10 Sep 2014 10:17:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 10:17:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAHp0W024380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 06:17:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAHnsv031465; Wed, 10 Sep 2014 06:17:50 -0400 Message-ID: <5410254D.4030507@redhat.com> Date: Wed, 10 Sep 2014 10:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH 2/9 v7] Introduce target/target.h References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-3-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-3-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00284.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > This introduces target/target.h. This file declares some functions > that the shared code can use and that clients must implement. It also > changes some shared code to use these functions. > > This patch differs from the version I posted on August 1 > (https://sourceware.org/ml/gdb-patches/2014-08/msg00014.html) in that > the target_stop, target_wait and target_resume parts have been split > into patch 3 of this series and that target_read_uint32's result is > now a uint32_t. OK. Thanks, Pedro Alves > > gdb/ChangeLog: > > * target/target.h: New file. > * Makefile.in (HFILES_NO_SRCDIR): Add target/target.h. > * target.h: Include target/target.h. > (target_read_memory, target_write_memory): Don't declare. > * target.c (target_read_uint32): New function. > * common/agent.c: Include target/target.h. > [!GDBSERVER]: Don't include target.h. > (helper_thread_id): Type changed to uint32_t. > (agent_get_helper_thread_id): Use target_read_uint32. > (agent_run_command): Always use target_read_memory and > target_write_memory. > (agent_capability): Type changed to uint32_t. > (agent_capability_check): Use target_read_uint32. > > gdb/gdbserver/ChangeLog: > > * target.h: Include target/target.h. > * target.c (target_read_memory, target_read_uint32) > (target_write_memory): New functions.