From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1605 invoked by alias); 10 Sep 2014 10:09:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1595 invoked by uid 89); 10 Sep 2014 10:09:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 10:09:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8AA9jTe020861 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 06:09:45 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8AA9hx2026328; Wed, 10 Sep 2014 06:09:44 -0400 Message-ID: <54102367.5080908@redhat.com> Date: Wed, 10 Sep 2014 10:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH 1/9 v7] Introduce show_debug_regs References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-2-git-send-email-gbenson@redhat.com> In-Reply-To: <1409320299-6812-2-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00282.txt.bz2 On 08/29/2014 02:51 PM, Gary Benson wrote: > - if (debug_hw_points) > + if (show_debug_regs) > fprintf_unfiltered > (gdb_stdlog, > "insert_hw_breakpoint on entry (addr=0x%08lx, len=%d))\n", > @@ -1208,7 +1204,7 @@ aarch64_linux_insert_hw_breakpoint (struct target_ops *self, > > ret = aarch64_handle_breakpoint (type, addr, len, 1 /* is_insert */); > > - if (debug_hw_points > 1) > + if (show_debug_regs) > { Please mention this change (and others like it, afaics, only in the Aarch64 port) in the commit log. This is changing behavior, but we're left with no clue on whether it was investigated and decided the change is desirable. The previous intention seems to be to only show the debug output if a higher verbosity level was shown. Like e.g., "maint set show-debug-regs 2". But, Aarch64's "maint set show-debug-regs" command is registered as a boolean command, so there is actually no way currently AFAICS for debug_hw_points to end up '> 1'. So that was actually dead code, and this change makes it undead. That is fine with me, and this is just debug code, and we can always remove it if it ends up too verbose. Doug was also OK with the patch, so go ahead and push with the commit log adjusted. Thanks, Pedro Alves