From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25272 invoked by alias); 8 Sep 2014 13:19:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25251 invoked by uid 89); 8 Sep 2014 13:19:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Sep 2014 13:19:35 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s88DJWjJ023179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Sep 2014 09:19:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s88DJUk6008690; Mon, 8 Sep 2014 09:19:31 -0400 Message-ID: <540DACE2.9060400@redhat.com> Date: Mon, 08 Sep 2014 13:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Adrian Sendroiu CC: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack. References: <53D8DA80.8010603@redhat.com> <1406819332-24242-1-git-send-email-adrian.sendroiu@freescale.com> <53DA6D73.5050906@redhat.com> <53E0E251.7040803@freescale.com> In-Reply-To: <53E0E251.7040803@freescale.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00180.txt.bz2 On 08/05/2014 02:55 PM, Adrian Sendroiu wrote: > There's also the 1/2 patch from the series that needs to be applied > before this. > > https://sourceware.org/ml/gdb-patches/2014-07/msg00574.html Ah. Silly me, completely missed that. The test indeed passes cleanly for me with that applied. > + mi_expect_stop "breakpoint-hit" "do_nothing" ".*" ".*" ".*" {".*" ".*"} "Continue to breakpoint" > + > + # This will crash gdb if redirection is not done properly. > + mi_gdb_test "help" ".*" "nested redirect" I think it'd be good to replace this ".*" with a stricter match, just in case something goes wrong with undoing the redirection, but nothing crashes. Something like (untested): mi_gdb_test "help" "List of classes of commands.*\\^done.*" "nested redirect" This is OK with a change along those lines. Thanks! Pedro Alves