From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12731 invoked by alias); 5 Sep 2014 16:06:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12722 invoked by uid 89); 5 Sep 2014 16:06:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Sep 2014 16:06:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s85G6lRT010463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Sep 2014 12:06:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s85G6ibr022999; Fri, 5 Sep 2014 12:06:45 -0400 Message-ID: <5409DF94.9050904@redhat.com> Date: Fri, 05 Sep 2014 16:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Adrian Sendroiu CC: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack. References: <53D8DA80.8010603@redhat.com> <1406819332-24242-1-git-send-email-adrian.sendroiu@freescale.com> <53DA6D73.5050906@redhat.com> <53E0E251.7040803@freescale.com> In-Reply-To: <53E0E251.7040803@freescale.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00149.txt.bz2 Hi Adrian, On 08/05/2014 02:55 PM, Adrian Sendroiu wrote: >> It's better to use $bpnum instead of hardcoding 2, as otherwise if someone adds a >> test that adds another breakpoint before this, this test stops being >> effective, silently. > > done > >>> + mi_gdb_test "-exec-continue" ".*" >> >> This should use mi_send_resuming_command/mi_expect_stop >> or mi_execute_to, so that the test works when the whole MI >> testsuite is run in async mode. > > done. Although I ran into another problem here, because mi_expect_stop expects a > message that looks like *stopped + prompt, while in my case it was something like > *stopped + =breakpoint-modified + prompt. I solved this by doing an even simpler > test case: just executing two python commands nested inside one another, like > "python gdb.execute('python gdb.execute(...". > > >> I think that we can avoid this duplication by renaming >> skip_python_tests, adding it a prompt_re parameter, and >> using that instead of $gdb_prompt. Something like: >> >> proc skip_python_tests {} { >> skip_python_tests_prompt "$gdb_prompt $" >> } >> >> proc mi_skip_python_tests { >> skip_python_tests_prompt "$mi_gdb_prompt$" >> } >> >> Did you try that? > > done > Thanks. I'm getting these with this patch: Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.mi/mi-logging.exp ... PASS: gdb.mi/mi-logging.exp: breakpoint at main PASS: gdb.mi/mi-logging.exp: mi runto main PASS: gdb.mi/mi-logging.exp: logging on PASS: gdb.mi/mi-logging.exp: logged step PASS: gdb.mi/mi-logging.exp: logged next ERROR: Got interactive prompt. UNRESOLVED: gdb.mi/mi-logging.exp: logging off PASS: gdb.mi/mi-logging.exp: Log file contents ERROR: Got interactive prompt. UNRESOLVED: gdb.mi/mi-logging.exp: redirect logging on ERROR: Got interactive prompt. UNRESOLVED: gdb.mi/mi-logging.exp: redirect logging off FAIL: gdb.mi/mi-logging.exp: Redirect log file contents FAIL: gdb.mi/mi-logging.exp: verify python support (GDB internal error) ERROR: Could not resync from internal error (timeout) UNRESOLVED: gdb.mi/mi-logging.exp: check if python 3 (got interactive prompt) ERROR: tcl error sourcing /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.mi/mi-logging.exp. ERROR: can't read "gdb_py_is_py3k": no such variable while executing ... gdb.log shows: Expecting: ^(-gdb-set logging off[ ]+)?(.*[ ]+[(]gdb[)] [ ]*) -gdb-set logging off ^done~"/home/pedro/gdb/mygit/src/gdb/mi/mi-out.c:398: internal-error: VEC_ui_filep_last: Assertion `last' failed.\nA problem internal to GDB has been detected,\nfurther deb ugging may prove unreliable.\nQuit this debugging session? " ~"(y or n) " ERROR: Got interactive prompt. UNRESOLVED: gdb.mi/mi-logging.exp: logging off PASS: gdb.mi/mi-logging.exp: Log file contents Expecting: ^(-gdb-set logging redirect on[ ]+)?(.*[ ]+[(]gdb[)] [ ]*) Any idea what went wrong ? Thanks, Pedro Alves