From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30590 invoked by alias); 5 Sep 2014 15:41:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30498 invoked by uid 89); 5 Sep 2014 15:41:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Sep 2014 15:41:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s85FfjxD013602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Sep 2014 11:41:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s85Ffigd000977; Fri, 5 Sep 2014 11:41:45 -0400 Message-ID: <5409D9B8.3050100@redhat.com> Date: Fri, 05 Sep 2014 15:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/2] Add dprintf and detach test (PR breakpoints/17012) References: <1408734315-21207-1-git-send-email-simon.marchi@ericsson.com> <1408734315-21207-2-git-send-email-simon.marchi@ericsson.com> <54089744.2030702@redhat.com> <5408B159.20203@ericsson.com> In-Reply-To: <5408B159.20203@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00148.txt.bz2 On 09/04/2014 07:37 PM, Simon Marchi wrote: > On 14-09-04 12:45 PM, Pedro Alves wrote: >> On 08/22/2014 08:05 PM, Simon Marchi wrote: >> >> >>> Until the remote case is sorted out, would it be ok to disable the >>> test for all remote targets or KFAIL the tests? I will tackle the >>> blocking problems in separate patches. >> >> Sure. > > I am not sure how to do this though. Is this ok? Looks like it. Alternatively, you can use setup_kfail and always do the re-attach. > > # Disable this test when using gdb for now (the inferior crashes when > # detaching due to PR 17302). > set test "re-attach to inferior" > if ![gdb_is_target_remote] { > # Give some time for the ex-inferior to run and hopefully not crash. > sleep 1 > > gdb_test "attach $inferior_pid" "Attaching to program: $escapedbinfile, process $inferior_pid.*Reading symbols from.*" "$test" > } else { > kfail "breakpoints/17302" "$test" "server/17302" > } > > I know that "remote" does not necessarily means gdbserver, but I don't > know how to check for gdbserver specifically. There's a check in qtro.exp you could reuse. See "probe for GDBserver". Thanks, Pedro Alves