From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19414 invoked by alias); 4 Sep 2014 10:52:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19401 invoked by uid 89); 4 Sep 2014 10:52:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Sep 2014 10:52:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s84Aq60Y009202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Sep 2014 06:52:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s84Aq5ra031771; Thu, 4 Sep 2014 06:52:05 -0400 Message-ID: <54084454.5060207@redhat.com> Date: Thu, 04 Sep 2014 10:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Pedro Alves , Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Ensure rl_get_screen_size() returns the actual terminal dimensions References: <1409534708-31981-1-git-send-email-patrick@parcs.ath.cx> <54084361.1020906@redhat.com> In-Reply-To: <54084361.1020906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00112.txt.bz2 On 09/04/2014 11:48 AM, Pedro Alves wrote: > On 09/01/2014 02:25 AM, Patrick Palka wrote: >> We should call rl_resize_terminal() before calling rl_get_screen_size() >> to help ensure that rl_get_screen_size() will return the correct >> terminal dimensions. Doing so fixes a couple issues where TUI does not >> correctly resize itself due to rl_get_screen_size() returning stale >> terminal dimensions. >> >> * tui/tui-win.c (tui_resize_all): Call rl_resize_terminal before >> calling rl_get_screen_size. > > OK. Actually, I take that back, for a moment. readline's rl_sigwinch_handler already call rl_resize_terminal, and then chains into the TUI's handler. So, why do we need this? Thanks, Pedro Alves