From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13640 invoked by alias); 4 Sep 2014 09:44:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13533 invoked by uid 89); 4 Sep 2014 09:44:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Sep 2014 09:44:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s849ibFV021751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Sep 2014 05:44:37 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s849iZY4024797; Thu, 4 Sep 2014 05:44:36 -0400 Message-ID: <54083483.6080502@redhat.com> Date: Thu, 04 Sep 2014 09:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix truncation of TUI command history References: <1409422278-19284-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1409422278-19284-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00109.txt.bz2 Hi Patrick, On 08/30/2014 07:11 PM, Patrick Palka wrote: > index aa14790..eee5f1ac6 100644 > --- a/gdb/tui/tui-io.c > +++ b/gdb/tui/tui-io.c > @@ -678,8 +678,9 @@ tui_getc (FILE *fp) > } > else > { > + /* Move cursor to the end of the command line. */ > wmove (w, TUI_CMD_WIN->detail.command_info.cur_line, > - TUI_CMD_WIN->detail.command_info.curch); > + strlen (tui_rl_saved_prompt) + rl_end); > waddch (w, ch); Does this still do the right thing with secondary prompts? E.g., if you do "quit" while a program is running, and then press enter a few times just to have the query repeat (and then pagination kick in, for extra stress). Thanks, Pedro Alves