Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Marcus Shawcroft <marcus.shawcroft@gmail.com>,
	       Catalin Udma <catalin.udma@freescale.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] aarch64/gdbserver: fix floating point registers display
Date: Tue, 02 Sep 2014 14:12:00 -0000	[thread overview]
Message-ID: <5405D022.7040101@redhat.com> (raw)
In-Reply-To: <CAFqB+Pz9ns9dEnnoUhd+c_JdE275ULJoWpLF8xMsPE=J==Cffg@mail.gmail.com>

On 09/02/2014 02:47 PM, Marcus Shawcroft wrote:

>> gdb/gdbserver/
>> 2014-08-12  Catalin Udma  <catalin.udma@freescale.com>
>>
>>         * linux-aarch64-low.c (AARCH64_FPSR_REGNO): New define.
>>         (AARCH64_FPCR_REGNO): Likewise.
>>         (AARCH64_NUM_REGS): Update to include fpsr/fpcr registers.
>>         (aarch64_fill_fpregset): Add missing fpsr/fpcr registers.
>>         (aarch64_store_fpregset): Likewise.
> 
> This looks good to me.... 

> .. however... I can't approve your patch here in gdb land.

<rubberstamp> OK </rubberstamp>

Please push.

Thanks,
Pedro Alves


  parent reply	other threads:[~2014-09-02 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22  6:59 Catalin Udma
2014-09-02 13:36 ` Marcus Shawcroft
2014-09-02 13:42   ` catalin.udma
     [not found] ` <CAFqB+Pz9ns9dEnnoUhd+c_JdE275ULJoWpLF8xMsPE=J==Cffg@mail.gmail.com>
2014-09-02 14:12   ` Pedro Alves [this message]
2014-09-16 14:00     ` catalin.udma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5405D022.7040101@redhat.com \
    --to=palves@redhat.com \
    --cc=catalin.udma@freescale.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marcus.shawcroft@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox