From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Rename 32- and 64-bit Intel files from "i386" to "x86"
Date: Tue, 02 Sep 2014 14:06:00 -0000 [thread overview]
Message-ID: <5405CEFA.5000100@redhat.com> (raw)
In-Reply-To: <20140902122820.GA13324@blade.nx>
On 09/02/2014 01:28 PM, Gary Benson wrote:
> Gary Benson wrote:
>> I found three more files that needed renaming.
>> Updated patch inlined below.
>> I will reply to this message with a "git diff -M" version.
>
> "git diff -M" version as promised.
>
Thanks, that helps.
I like this. Getting these little details
consistent throughout should make it for reading/grokking the
code base a little easier. Fewer surprises should mean happier
newcomers.
Given that when we last discussed this naming convention on the
list (*), objections were addressed and no further
objections came around, I think we should go right ahead
before this bit rots.
Thus, OK.
Thanks!
* - https://sourceware.org/ml/gdb-patches/2014-06/msg00931.html
Pedro Alves
next prev parent reply other threads:[~2014-09-02 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 13:06 [PATCH] " Gary Benson
2014-09-02 12:24 ` [PATCH v2] " Gary Benson
2014-09-02 12:34 ` Gary Benson
2014-09-02 14:06 ` Pedro Alves [this message]
2014-09-02 15:55 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5405CEFA.5000100@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox