From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30089 invoked by alias); 16 Jul 2018 14:02:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29977 invoked by uid 89); 16 Jul 2018 14:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:375, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 14:02:01 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6FE64002592; Mon, 16 Jul 2018 14:01:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A0A17C4F; Mon, 16 Jul 2018 14:01:59 +0000 (UTC) Subject: Re: [RFA 10/13] Remove unused declaration from value.c To: Simon Marchi , Tom Tromey References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> <877elyc11j.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <53ef4f69-ce98-a6e6-50b9-34b449b03a9e@redhat.com> Date: Mon, 16 Jul 2018 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00478.txt.bz2 On 07/13/2018 10:49 PM, Simon Marchi wrote: > Then my opinion would be to check if removing it causes any test failure.  If not, I'd remove it (in its own commit such as this patch is good, so it's easy to bisect if needed). Agreed. If/when we find out it was needed, we can add a testcase then. Thanks, Pedro Alves