From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EV1JHGdNa2p9zjQAWB0awg (envelope-from ) for ; Thu, 30 Jul 2026 09:11:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2YqTyfO5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OqOolPp1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UTT7AqQN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3XdNBlhi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6CBD31E09E; Thu, 30 Jul 2026 09:11:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B8CEF1E099 for ; Thu, 30 Jul 2026 09:11:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D4234BBC0E9 for ; Thu, 30 Jul 2026 13:11:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D4234BBC0E9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2YqTyfO5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OqOolPp1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UTT7AqQN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3XdNBlhi Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 345BB4BA2E05 for ; Thu, 30 Jul 2026 13:10:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 345BB4BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 345BB4BA2E05 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785417035; cv=none; b=owwZ1VqodczRmrAS8bkSb1HClRSpDG9Ciz8SNSXPRZEf/P0jmbJrDf3FELiRMVJp3po9yB+Gr5CNypGrqiZfaxm+OdCB3HmEtBK3xNd1ucliqPJxpxJgxSNKWfdQ6pMfmEhd/K6wHWNWrxFlT3ez1CqnPp7/BHGWC6UaFdWGjxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785417035; c=relaxed/simple; bh=rnE/4flYKNwhUEYmdKdeBY2fo0Arod7fN9DB1gCvpN8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=OWIKYxYjSgfir3psfKyzClfd67NoFKwrlsN8Zxu3dm1QRYaZRK8PDINXiksL9xOno/Rxs+OvxpDwyoPXgp20SSOlREOpSVDly2CKfgMdZjHdSTEw+mwwRDZKAeAcHtK6TlpxhH+RtrC4DWJ48ALPcxH3dsVcFvJRBegEO64trQE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2YqTyfO5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OqOolPp1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UTT7AqQN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3XdNBlhi DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 345BB4BA2E05 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2AC097D96A; Thu, 30 Jul 2026 13:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785417030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUHrNSJ7LWBkLduu0eYlMMidrSBrI0izoT0SM5O/QJU=; b=2YqTyfO5tb+NDp7E1GAyM4nUeWPp8ilcTVxGQZrLxaLoW0MkN5ZJEWH2nVzr0AczELVAcm C3KQoVbN4n7B+UWREX/5cnbCCPMhVGbcBJsBtzZMmpO+QVZSR83TjEeNt/+tN8hazd3jkD mTbrL26v9FQKbejlUMfsLdIBj8nryKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785417030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUHrNSJ7LWBkLduu0eYlMMidrSBrI0izoT0SM5O/QJU=; b=OqOolPp1SsbRXca/uSNfMsm2PeMyaowOZ8fzGA2DeOAH0tTu69mS9p066XnXPuhMqdBjx9 0d+fr4eEifCElrDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785417025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUHrNSJ7LWBkLduu0eYlMMidrSBrI0izoT0SM5O/QJU=; b=UTT7AqQNgE+X4Chu0LVyrdVdxFkgJGKGW+GuXmLAUW9NfVCPIJvVqb3+xDKcBzhnUZvPD4 /Hs5W+v1jrZY9dG55q7XIXhliy/1RQOZfXopzzhVtp9/9C2+KHQhN9nulutKAfIAK2I9ey OTvYOm2Wyva4Ib/siPDrJ91kdecWwpc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785417025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUHrNSJ7LWBkLduu0eYlMMidrSBrI0izoT0SM5O/QJU=; b=3XdNBlhiUEVdWdfi97sAnfbsXo+Vcxjx1NQrt+ryQ0TL9bd+p2XbrVh9OmPiMiMy9wC/ya EgrSWGPDvYgZvVCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 10971779CC; Thu, 30 Jul 2026 13:10:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +V3TAkFNa2qlUgAAD6G6ig (envelope-from ); Thu, 30 Jul 2026 13:10:25 +0000 Message-ID: <53b3354a-22da-4719-8e6a-af28d33a194f@suse.de> Date: Thu, 30 Jul 2026 15:10:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] Add shellcheck From: Tom de Vries To: Thiago Jung Bauermann , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260618151957.76500-1-tdevries@suse.de> <874iivunvq.fsf@linaro.org> <6174eca4-a189-4f38-bd69-a6312c361d20@suse.de> Content-Language: en-US In-Reply-To: <6174eca4-a189-4f38-bd69-a6312c361d20@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.992]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/22/26 12:02 PM, Tom de Vries wrote: > We could do something similar (no downloading) for shellcheck: > ... > diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml > index 9910bbb82f2..92c56d95977 100644 > --- a/.pre-commit-config.yaml > +++ b/.pre-commit-config.yaml > @@ -130,3 +130,10 @@ repos: >        language: unsupported_script >        entry: gdb/contrib/check-file-mode.sh >        files: '^(gdb|gdbserver|gdbsupport)/.*$' > +    - id: &id5 shellcheck > +      name: *id5 > +      language: unsupported > +      entry: shellcheck > +      files: '^(gdb|gdbsupport|gdbserver)/' > +      types: ['shell'] > +      exclude: '^(gdb/config/djgpp/(djcheck.sh|djconfig.sh)|gdb/ > contrib/ari/(create-web-ari- > in-src.sh|gdb_ari.sh|update-web-ari.sh)|gdb/contrib/(cc-with-tweaks.sh| > gdb-add-index.sh)|gdb/gdb_builda > ll.sh|gdb/gdb_mbuild.sh|gdb/regformats/regdat.sh|gdb/po/gdbtext|gdb/ > testsuite/lib/pdtrace.in)$|/configu > re$' > ... > > This means there's no easy installation, people have to install it > themselves. > > There's also no version pinning.  We could add a script that does a > version check though, and check for version 0.11.0. > I ended up using roughly this approach in a v3 ( https://sourceware.org/pipermail/gdb-patches/2026-July/229090.html ) but allowing both 0.10.0 and 0.11.0. Thanks, - Tom