From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] Fix latent bug in test_gdb_complete_cmd_multiple
Date: Fri, 28 Jun 2019 14:56:00 -0000 [thread overview]
Message-ID: <53a1cc84-3d75-f074-8ddd-862dd07343b2@redhat.com> (raw)
In-Reply-To: <871rzd223d.fsf@tromey.com>
On 6/28/19 3:53 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> if {$max_completions} {
> Pedro> + set cmd_prefix_re [string_to_regexp $cmd_prefix]
> Pedro> append expected_re \
> Pedro> - "$cmd_prefix \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n"
> Pedro> + "$cmd_prefix_re \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n"
> Pedro> }
>
> Pedro> set cmd_re [string_to_regexp "complete $cmd_prefix$completion_word"]
>
> It looks like this is going to end up running string_to_regexp twice --
> once in the "if" and then again here, which is probably not desirable.
It won't because the second time is still referring to $cmd_prefix,
while the new code introduces a new $cmd_prefix_re variable.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-06-28 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 19:14 [PATCH 0/5] pipe command completer, and string options Pedro Alves
2019-06-27 19:14 ` [PATCH 3/5] Teach gdb::option about " Pedro Alves
2019-06-28 15:11 ` Tom Tromey
2019-06-27 19:14 ` [PATCH 1/5] Fix test_gdb_complete_tab_multiple race Pedro Alves
2019-06-27 19:14 ` [PATCH 4/5] Fix latent bug in test_gdb_complete_cmd_multiple Pedro Alves
2019-06-28 14:53 ` Tom Tromey
2019-06-28 14:56 ` Pedro Alves [this message]
2019-06-28 15:46 ` Tom Tromey
2019-06-27 19:14 ` [PATCH 5/5] pipe command completer Pedro Alves
2019-06-28 15:16 ` Tom Tromey
2019-07-03 16:28 ` Pedro Alves
2019-06-27 19:14 ` [PATCH 2/5] Make gdb::option::complete_options save processed arguments too Pedro Alves
2019-06-28 15:16 ` [PATCH 0/5] pipe command completer, and string options Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53a1cc84-3d75-f074-8ddd-862dd07343b2@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox