From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15569 invoked by alias); 28 Aug 2014 15:39:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15560 invoked by uid 89); 28 Aug 2014 15:39:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Aug 2014 15:39:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7SFdbKe014071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 28 Aug 2014 11:39:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7SFdZL4017954; Thu, 28 Aug 2014 11:39:36 -0400 Message-ID: <53FF4D37.4080704@redhat.com> Date: Thu, 28 Aug 2014 15:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Make gdbserver use exceptions and cleanups References: <1408351618-21013-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1408351618-21013-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00620.txt.bz2 On 08/18/2014 09:46 AM, Gary Benson wrote: > gdbserver has the rudiments of an exception system, but it's kind of > hacky. This series converts gdbserver to use the same exceptions and > cleanups as GDB. > > This series is fairly minimal in that only the catch/cleanup code in > what was "main" has been updated to use the new system. Other parts > of gdbserver could likely be converted to TRY_CATCH and cleanups too, > but that can be done on an as-needed basis if this patch is accepted. > > A side-effect of this patch is that some error messages will change > slightly, and in cases with multiple errors the error messages will > be printed in a different order. > > Built and regtested on RHEL 6.5 x86_64. > > Ok to commit? Other than the minor nits I just picked in the responses to the patches, this looks great to me. Thanks a lot for doing this. Pedro Alves