From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22172 invoked by alias); 28 Aug 2014 14:27:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22147 invoked by uid 89); 28 Aug 2014 14:27:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Aug 2014 14:27:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7SERsCC014877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Aug 2014 10:27:54 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7SERqAb009604; Thu, 28 Aug 2014 10:27:53 -0400 Message-ID: <53FF3C68.6040905@redhat.com> Date: Thu, 28 Aug 2014 14:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Another board file for remote host References: <1409232690-24185-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1409232690-24185-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00615.txt.bz2 On 08/28/2014 02:31 PM, Yao Qi wrote: > In the recent review to my patch about copying files to remote host, > we find that we need a board file which is more closely mapped real > remote host testing to improve coverage. With the board file > local-remote-host-native.exp, DejaGNU copies files to /tmp/gdb/ to > emulate the effect of remote host. Is it OK? > > gdb/testsuite: > > 2014-08-28 Yao Qi > > * boards/local-remote-host-native.exp: New file. > --- > gdb/testsuite/boards/local-remote-host-native.exp | 79 +++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 gdb/testsuite/boards/local-remote-host-native.exp > > diff --git a/gdb/testsuite/boards/local-remote-host-native.exp b/gdb/testsuite/boards/local-remote-host-native.exp > new file mode 100644 > index 0000000..a3fd2dc > --- /dev/null > +++ b/gdb/testsuite/boards/local-remote-host-native.exp I'm confused on the choice of "native" for name. local-remote-host.exp/local-remote-host-notty.exp seem just or more more native to me, as they assume a shared filesystem, while the whole point of this one is emulate the case of _not_ sharing the filesystem? > +# To use this file: > +# bash$ cd ${build_dir}/gdb > +# bash$ make check RUNTESTFLAGS="--host_board=local-remote-host-native --target_board=local-remote-host-native" > + > +if { $board_type == "target" } { > + set_board_info compiler gcc Why do we need to also use the board as a target board? > +} > +if { $board_type == "host" } { > + set_board_info gdb_opts "-ex \"dir ${tmp_dir}\"" No biggie, but this: set_board_info gdb_opts "-d \"${tmp_dir}\"" looks a little simpler to me, just for the fact that it runs through less code / fewer indirections in GDB. > +} -- Thanks, Pedro Alves