From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26437 invoked by alias); 27 Aug 2014 10:17:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26422 invoked by uid 89); 27 Aug 2014 10:17:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 10:17:55 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RAHqrT018844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 06:17:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7RAHo2E016288; Wed, 27 Aug 2014 06:17:51 -0400 Message-ID: <53FDB04E.2050905@redhat.com> Date: Wed, 27 Aug 2014 10:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Omair Javaid , Will Newton CC: "gdb-patches@sourceware.org" , Patch Tracking Subject: Re: [PATCH v3 4/6] Implement support for recording extension register ld/st insn References: <1407935535-27978-1-git-send-email-omair.javaid@linaro.org> <1407935535-27978-5-git-send-email-omair.javaid@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00560.txt.bz2 On 08/27/2014 10:21 AM, Omair Javaid wrote: > + while (memory_count) > + { > + while (reg_count) Not implicit boolean coercion please. Write 'memory_count != 0' or 'memory_count > 0'. >>> >> + /* VLDR Vector load register. */ >>> >> + else if ((opcode & 0x13) == 0x11) >>> >> + { >>> >> + uint8_t single_reg = 0; >>> >> + uint8_t special_case; >> > >> > Is there some missing code here? Should there be a TODO comment? > Seems like a bit of code missing here will update it in the final patch. It's kind of hard to review code that we don't see... :-) Please post the updated patch. > Ping! Kindly provide your feedback any further comments will help me > approve this patch series. This is OK if Will is happy with the updated patch. Thanks, Pedro Alves