From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15496 invoked by alias); 27 Aug 2014 10:09:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15486 invoked by uid 89); 27 Aug 2014 10:09:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 10:09:45 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RA9haB010082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 06:09:43 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7RA9fpw012246; Wed, 27 Aug 2014 06:09:41 -0400 Message-ID: <53FDAE64.1070407@redhat.com> Date: Wed, 27 Aug 2014 10:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Omair Javaid , Will Newton CC: "gdb-patches@sourceware.org" , Patch Tracking Subject: Re: [PATCH v3 2/6] Implements support for recording thumb2 ASIMD struct ld/st insn References: <1407935535-27978-1-git-send-email-omair.javaid@linaro.org> <1407935535-27978-3-git-send-email-omair.javaid@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00558.txt.bz2 On 08/27/2014 10:07 AM, Omair Javaid wrote: > On 13 August 2014 19:10, Will Newton wrote: >> On 13 August 2014 14:12, Omair Javaid wrote: >>> gdb: >>> Same comments as previous patch on ChangeLog and $subject. Please likewise adjust all patches in the series. >>> +static int >>> +thumb2_record_asimd_struct_ld_st (insn_decode_record *thumb2_insn_r) >>> +{ >>> + struct regcache *reg_cache = thumb2_insn_r->regcache; >>> + uint32_t l_bit, a_bit, b_bits; >>> + uint32_t record_buf[128], record_buf_mem[128]; >>> + uint32_t reg_rn, reg_vd, address, f_esize, f_elem; >>> + uint32_t index_r = 0, index_e = 0, bf_regs = 0, index_m = 0, loop_t = 0; >>> + uint8_t bf_align, f_ebytes; >>> + >>> + l_bit = bit (thumb2_insn_r->arm_insn, 21); >>> + a_bit = bit (thumb2_insn_r->arm_insn, 23); >>> + b_bits = bits (thumb2_insn_r->arm_insn, 8, 11); >>> + bf_align = bits (thumb2_insn_r->arm_insn, 4, 5); >> >> bf_align does not appear to be used. >> >>> + reg_rn = bits (thumb2_insn_r->arm_insn, 16, 19); >>> + reg_vd = bits (thumb2_insn_r->arm_insn, 12, 15); >>> + reg_vd = (bit (thumb2_insn_r->arm_insn, 22) << 4) | reg_vd; >>> + f_ebytes = (1 << bits (thumb2_insn_r->arm_insn, 6, 7)); >> >> The outer brackets are redundant. > Ping! Kindly provide your feedback and help me approve this patch series. This is OK with Will's comments addressed. Thanks, Pedro Alves