From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11020 invoked by alias); 27 Aug 2014 10:05:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11010 invoked by uid 89); 27 Aug 2014 10:05:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 10:05:28 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RA5P6i008005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 06:05:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7RA5OWk006125; Wed, 27 Aug 2014 06:05:24 -0400 Message-ID: <53FDAD63.9040306@redhat.com> Date: Wed, 27 Aug 2014 10:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Omair Javaid , Will Newton CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v3 1/6] Implements support for recording arm/thumb mode coprocessor instructions References: <1407935535-27978-1-git-send-email-omair.javaid@linaro.org> <1407935535-27978-2-git-send-email-omair.javaid@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00557.txt.bz2 Hi Omair, On 08/27/2014 10:07 AM, Omair Javaid wrote: > On 13 August 2014 19:10, Will Newton wrote: >> On 13 August 2014 14:12, Omair Javaid wrote: >>> gdb: >>> >From the nit department: >>> 2014-08-13 Omair Javaid >>> >>> * arm-tdep.c (arm_record_coproc_data_proc): Updated. please use imperative, present tense in logs. Also in the $subject line when that gets into the commit log: s/Implements/Implement/. And, updated how? What changed? Please write something like: * arm-tdep.c (arm_record_coproc_data_proc): Handle foo instructions. with 'foo' replaced, of course. :-) >>> (arm_record_asimd_vfp_coproc): Added record handler for asimd, vfp >>> and coprocessor insn. 'Add'. >>> (thumb2_record_coproc_insn): New function. >>> (thumb2_record_decode_insn_handler): Updated. Likewise, updated how? >>> (decode_insn): Updated. Say something like: (decode_insn): Install arm_record_asimd_vfp_coproc as handler for opcode 110 insns. >>> +/* Handling opcode 110 insns. */ >>> + >>> +static int >>> +arm_record_asimd_vfp_coproc (insn_decode_record *arm_insn_r) >>> +{ >>> + uint32_t op, op1, op1_sbit, op1_ebit, coproc; >>> + >>> + coproc = bits (arm_insn_r->arm_insn, 8, 11); >>> + op1 = bits (arm_insn_r->arm_insn, 20, 25); >>> + op1_sbit = bit (arm_insn_r->arm_insn, 24); >>> + op1_ebit = bit (arm_insn_r->arm_insn, 20); >>> + op = bit (arm_insn_r->arm_insn, 4); >> >> op abd op1_sbit appear to be unused. > Ping! Kindly provide your feedback and help me approve this patch series. I didn't see a reply to Will's comment. Should op1_sbit haven been used? This patch is OK once Will is happy with it. Thanks, Pedro Alves