From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26819 invoked by alias); 20 Aug 2014 17:36:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26711 invoked by uid 89); 20 Aug 2014 17:36:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 17:36:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KHZpnr029449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 13:35:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KHZm41002268; Wed, 20 Aug 2014 13:35:49 -0400 Message-ID: <53F4DC74.8080807@redhat.com> Date: Wed, 20 Aug 2014 17:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Richard Earnshaw , Yao Qi CC: Philippe Waroquiers , Catalin Udma , "gdb-patches@sourceware.org" Subject: Re: [PATCH] aarch64/gdbserver: fix floating point registers display References: <1407835166-827-1-git-send-email-catalin.udma@freescale.com> <53E9E1C2.6010707@arm.com> <53E9EB9A.7000304@codesourcery.com> <1407932734.2182.67.camel@soleil> <53EB5C86.4030307@codesourcery.com> <53EB7965.8070208@arm.com> In-Reply-To: <53EB7965.8070208@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00422.txt.bz2 On 08/13/2014 03:42 PM, Richard Earnshaw wrote: > On 13/08/14 13:39, Yao Qi wrote: >> On 08/13/2014 08:25 PM, Philippe Waroquiers wrote: >>> The 'it' in 'fix it' is ambiguous to me. >>> Does the 'it' mean: >>> fix aarch64-core.xml to change cpsr to 32 bits ? >> >> That was what I meant, however .... >> >>> or does that confirm the initial proposal i.e. >>> fix e.g. aarch64.dat to change cpsr to 64 bits ? >> >> ... I find a patch changed cpsr to 64 bit in last Dec. >> >> [PATCH] AARCH64: Change cpsr type to be 64bit. >> https://sourceware.org/ml/gdb-patches/2013-12/msg00720.html >> >> and looks aarch64.dat was not updated together in this patch. >> >> I am sure that aarch64.dat and aarch64-core.xml are not in sync, >> but I don't know which way to go, sorry. >> > > Changing the XML doesn't sound like the right way forward, the XML can > be embedded into other components as part of the register description > interface. > > Hmm, I can't see where anyone ever formally approved that change. In > fact, Mark K commented at the time: > > "Basing GDB's fundamentals on a particular OS's ptrace(2) > implementation is a bad idea." > > So it seems to me that that change was indeed incorrect and should > probably be reverted (at least in its current incarnation). I agree, and I'm surprised to learn the patch went in. :-/ Thanks, Pedro Alves