From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13529 invoked by alias); 20 Aug 2014 15:40:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13514 invoked by uid 89); 20 Aug 2014 15:40:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 15:40:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KFeiIp004967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 11:40:44 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KFehOE007597; Wed, 20 Aug 2014 11:40:43 -0400 Message-ID: <53F4C17A.9060802@redhat.com> Date: Wed, 20 Aug 2014 15:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Check function is GC'ed References: <53D8A264.1050103@codesourcery.com> <1407307813-5321-1-git-send-email-yao@codesourcery.com> <1407307813-5321-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1407307813-5321-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00410.txt.bz2 On 08/06/2014 07:50 AM, Yao Qi wrote: > @@ -17291,7 +17293,12 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir, > case DW_LNE_set_address: > address = read_address (abfd, line_ptr, cu, &bytes_read); > > - if (address == 0 && !dwarf2_per_objfile->has_section_at_zero) > + if (!decode_for_pst_p) > + pst = cu->per_cu->v.psymtab; > + > + if (address == 0 > + && (!dwarf2_per_objfile->has_section_at_zero > + || (pst != NULL && pst->textlow > address))) > { > /* This line table is for a function which has been > GCd by the linker. Ignore it. PR gdb/12528 */ Does this still work when we have .gdb_index sections? ISTR we don't have psymtabs in that case? Thanks, Pedro Alves