From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12309 invoked by alias); 20 Aug 2014 15:04:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12287 invoked by uid 89); 20 Aug 2014 15:04:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 15:04:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KF4Bok031177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 11:04:11 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KF48YD029084; Wed, 20 Aug 2014 11:04:09 -0400 Message-ID: <53F4B8E8.7030108@redhat.com> Date: Wed, 20 Aug 2014 15:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , Doug Evans CC: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-12-git-send-email-gbenson@redhat.com> <21474.30047.278277.20526@ruffy.mtv.corp.google.com> <20140807123859.GB19737@blade.nx> In-Reply-To: <20140807123859.GB19737@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00406.txt.bz2 On 08/07/2014 01:38 PM, Gary Benson wrote: > Doug Evans wrote: >> Gary Benson writes: >> > @@ -35,6 +29,8 @@ static inline void >> > linux_debug (const char *format, ...) >> > { >> > #ifdef GDBSERVER >> > + extern int debug_threads; >> > + >> >> Recognizing that this is a temporary hack, ok by me. >> Can I ask you to add a FIXME here though? > > I added: > > /* FIXME: This conditional code and hacky extern are necessary now, > but should be removed when GDB's and gdbserver's Linux thread_db > implementations are unified and moved into the nat directory. */ No. This file (linux-waitpid.c) really has nothing to do with thread_db (glibc interface). It's part of the kernel/ptrace layer. If we wanted this particular debug output enabled on GDB, then it'd be guarded by 'debug_linux_nat' (set debug lin-lwp 1). There's really no good reason for GDB and GDBserver to be different here, other than the history of this waitpid wrapper and how it ended up used in gdb as well. The "threads" in "debug_threads" in gdbserver is just a historic wart. That global really means "global/generic debug traces enabled". It was the only debug flag that existed in gdbserver for a long while, and nobody ever renamed it. -- Thanks, Pedro Alves