Re: [PATCH] Support _Complex in hard-VFP abi

Pedro Alves
2014-08-19T22:44:38Z

On 08/19/2014 02:12 PM, Yao Qi wrote:
> On 08/11/2014 09:12 PM, Will Newton wrote:
>>>> + case TYPE_CODE_COMPLEX:
>>>> + /* Arguments of complex T where T is one of the types float or
>>>> + double get treated as if they are implemented as:
>>>> +
>>>> + struct complexT
>>>> + {
>>>> + T real;
>>>> + T imag;
>>>> + };*/
>> A line break before closing the comment might look nicer here.
>>
>
> I add two spaces before closing the comment, because we don't move
> "*/" to a separated line.

...

> + case TYPE_CODE_COMPLEX:
> + /* Arguments of complex T where T is one of the types float or
> + double get treated as if they are implemented as:
> +
> + struct complexT
> + {
> + T real;
> + T imag;
> + }; */
> + switch (TYPE_LENGTH (t))

This is borderline pedantry, but this looks ugly enough to me that
I'll speak up in case this ends up being the norm. :-) FWIW, I agree
with Will here -- I think we should make an exception to the rule
in the cases where the comment is actually a paste of output,
multiline code or similar cases. It's kind of like a @smallexample
region in texinfo, that begs to be rendered on its own block/lines,
separate from the text around it.

'grep -n "^[ |\t]\+\*/" *.h -B 3' finds several (many?) similar
examples (and a bunch of wrong-format comments too, though..)

<nit mode/>

Thanks,
Pedro Alves