Re: [PATCH] Support _Complex in hard-VFP abi

Yao Qi
2014-08-19T00:55:43Z

On 08/11/2014 08:51 PM, Yao Qi wrote:
> The hard-VFP ABI was supported by GDB overal, done by this patch
> https://sourceware.org/ml/gdb-patches/2009-07/msg00686.html but
> "vectors and complex types are not currently supported", mentioned in
> the patch. As a result, these tests fail.
>
> This patch is to support _Complex types in hard-VFP abi. As specified
> in "7.1.1, Procedure Call Standard for the ARM Arch", the layout of
> _Complex types is a struct, which is identical to the layout on amd64,
> so I copy Mark's comments to amd64 support.
>
> Regression tested on arm-none-eabi target. OK to apply?
>
> gdb:
>
> 2014-08-11 Yao Qi <yao@codesourcery.com>
>
> * arm-tdep.c (arm_vfp_cprc_sub_candidate): Handle _Complex
> types.

Beside Will's review on code comments, any other review?
https://sourceware.org/ml/gdb-patches/2014-08/msg00182.html

--
Yao (é½å°§)