Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: [OB/PUSHED] Remove stale comment (was: Re: [PATCH] Set breakpoint on the right line)
Date: Tue, 19 Aug 2014 17:20:00 -0000	[thread overview]
Message-ID: <53F3876A.6060806@redhat.com> (raw)
In-Reply-To: <1407806302-14295-1-git-send-email-yao@codesourcery.com>

On 08/12/2014 02:18 AM, Yao Qi wrote:
> 
>   /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
>      already stays on the line PC while entering "step"/"continue".  */

I noticed that this comment is stale.  This is no longer true for
watchpoints.  I've pushed this as obvious.

-------------------------
Remove stale comment

This comment is no longer true for watchpoints since commit 31e77af2
(PR breakpoints/7143 - Watchpoint does not trigger when first set).

gdb/testsuite/

	* gdb.base/watchpoint-hw-hit-once.c (main): Update comment.
---
 gdb/testsuite/ChangeLog                         | 4 ++++
 gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 060c7a1..d30f7a3 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-19  Pedro Alves  <palves@redhat.com>
+
+	* gdb.base/watchpoint-hw-hit-once.c (main): Update comment.
+
 2014-08-19  Yao Qi  <yao@codesourcery.com>
 
 	* gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the
diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
index 8ba8ca4..aa64f1d 100644
--- a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
+++ b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
@@ -22,7 +22,7 @@ main (void)
 {
   volatile int dummy;
 
-  /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
+  /* Stub lines are present as no breakpoint gets hit if current PC
      already stays on the line PC while entering "step"/"continue".  */
 
   dummy = 0;	/* Stub to catch WATCHEE access after runto_main.  */
-- 
1.9.3



      parent reply	other threads:[~2014-08-19 17:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12  1:22 [PATCH] Set breakpoint on the right line Yao Qi
2014-08-19  0:50 ` Yao Qi
2014-08-19  6:38 ` Joel Brobecker
2014-08-19 13:35   ` Yao Qi
2014-08-19 13:48     ` Joel Brobecker
2014-08-20  0:21       ` Yao Qi
2014-08-19 17:20 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F3876A.6060806@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox