From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18823 invoked by alias); 19 Aug 2014 00:55:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18806 invoked by uid 89); 19 Aug 2014 00:55:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Aug 2014 00:55:40 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XJXi5-0001iD-97 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 18 Aug 2014 17:55:37 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 18 Aug 2014 17:55:37 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Mon, 18 Aug 2014 17:55:36 -0700 Message-ID: <53F29F9D.9050601@codesourcery.com> Date: Tue, 19 Aug 2014 00:55:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Subject: Re: [PATCH] Support _Complex in hard-VFP abi References: <1407761487-9251-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1407761487-9251-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00325.txt.bz2 On 08/11/2014 08:51 PM, Yao Qi wrote: > The hard-VFP ABI was supported by GDB overal, done by this patch > https://sourceware.org/ml/gdb-patches/2009-07/msg00686.html but > "vectors and complex types are not currently supported", mentioned in > the patch. As a result, these tests fail. > > This patch is to support _Complex types in hard-VFP abi. As specified > in "7.1.1, Procedure Call Standard for the ARM Arch", the layout of > _Complex types is a struct, which is identical to the layout on amd64, > so I copy Mark's comments to amd64 support. > > Regression tested on arm-none-eabi target. OK to apply? > > gdb: > > 2014-08-11 Yao Qi > > * arm-tdep.c (arm_vfp_cprc_sub_candidate): Handle _Complex > types. Beside Will's review on code comments, any other review? https://sourceware.org/ml/gdb-patches/2014-08/msg00182.html -- Yao (齐尧)