From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14799 invoked by alias); 19 Aug 2014 00:50:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14784 invoked by uid 89); 19 Aug 2014 00:50:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Aug 2014 00:50:52 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XJXdQ-0000cw-Ci from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 18 Aug 2014 17:50:48 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 18 Aug 2014 17:50:47 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 18 Aug 2014 17:50:46 -0700 Message-ID: <53F29E7B.2080602@codesourcery.com> Date: Tue, 19 Aug 2014 00:50:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Subject: Re: [PATCH] Set breakpoint on the right line References: <1407806302-14295-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1407806302-14295-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00324.txt.bz2 On 08/12/2014 09:18 AM, Yao Qi wrote: > In gdb.base/watchpoint-hw-hit-once.exp, test scans source and set > breakpoint on the line having "break-at-exit", > > gdb_breakpoint [gdb_get_line_number "break-at-exit"] > > However, in watchpoint-hw-hit-once.c, there are two lines having > this key word: > > dummy = 1; /* Stub to catch break-at-exit after WATCHEE has been hit. */ > dummy = 2; /* break-at-exit */ > > so the test sets breakpoint on the first one, while I think it is > expected to set breakpoint on the second one, as far as I can tell > from the comments in watchpoint-hw-hit-once.c: > > /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC > already stays on the line PC while entering "step"/"continue". */ > > This patch is to change the source matching pattern so that test > can correctly set breakpoint on the right line. This patch fixes > a fail we found on arm-none-eabi target. Run it again > on x86_64-linux, no result changes. > > gdb/testsuite: > > 2014-08-12 Yao Qi > > * gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the > right line. Ping. https://sourceware.org/ml/gdb-patches/2014-08/msg00190.html -- Yao (齐尧)