From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9120 invoked by alias); 13 Aug 2014 14:42:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9111 invoked by uid 89); 13 Aug 2014 14:42:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Aug 2014 14:42:49 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 13 Aug 2014 15:42:46 +0100 Received: from [10.1.208.33] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 13 Aug 2014 15:42:46 +0100 Message-ID: <53EB7965.8070208@arm.com> Date: Wed, 13 Aug 2014 14:42:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Yao Qi CC: Philippe Waroquiers , Catalin Udma , "gdb-patches@sourceware.org" Subject: Re: [PATCH] aarch64/gdbserver: fix floating point registers display References: <1407835166-827-1-git-send-email-catalin.udma@freescale.com> <53E9E1C2.6010707@arm.com> <53E9EB9A.7000304@codesourcery.com> <1407932734.2182.67.camel@soleil> <53EB5C86.4030307@codesourcery.com> In-Reply-To: <53EB5C86.4030307@codesourcery.com> X-MC-Unique: 114081315424611401 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00238.txt.bz2 On 13/08/14 13:39, Yao Qi wrote: > On 08/13/2014 08:25 PM, Philippe Waroquiers wrote: >> The 'it' in 'fix it' is ambiguous to me. >> Does the 'it' mean: >> fix aarch64-core.xml to change cpsr to 32 bits ? >=20 > That was what I meant, however .... >=20 >> or does that confirm the initial proposal i.e. >> fix e.g. aarch64.dat to change cpsr to 64 bits ? >=20 > ... I find a patch changed cpsr to 64 bit in last Dec. >=20 > [PATCH] AARCH64: Change cpsr type to be 64bit. > https://sourceware.org/ml/gdb-patches/2013-12/msg00720.html >=20 > and looks aarch64.dat was not updated together in this patch. >=20 > I am sure that aarch64.dat and aarch64-core.xml are not in sync, > but I don't know which way to go, sorry. >=20 Changing the XML doesn't sound like the right way forward, the XML can be embedded into other components as part of the register description interface. Hmm, I can't see where anyone ever formally approved that change. In fact, Mark K commented at the time: "Basing GDB's fundamentals on a particular OS's ptrace(2) implementation is a bad idea." So it seems to me that that change was indeed incorrect and should probably be reverted (at least in its current incarnation). R.