Re: Warnings in native MinGW32 build of GDB 7.8

Yao Qi
2014-08-13T04:11:18Z

On 08/09/2014 10:09 PM, Eli Zaretskii wrote:
> I fixed that as below, but I wonder why no one else saw this. is this
> because I use an ancient version of GCC?

I don't see any warning in my mingw32 build. I am using
i686-w64-mingw32-gcc 4.8.2.

>
> OK to commit the below (master and 7.8 branch), with suitable
> ChangeLog entries?
>
> --- gdb/dcache.c~0 2014-07-29 15:37:42.000000000 +0300
> +++ gdb/dcache.c 2014-08-09 16:17:31.823000000 +0300
> @@ -18,6 +18,7 @@
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> #include "defs.h"
> +#include "target.h" /* for 'enum target_xfer_status' */

I can see enum target_xfer_status is used in this c file. This is good
to me.

> #include "dcache.h"
> #include "gdbcmd.h"
> #include <string.h>
>
> --- gdb/defs.h~0 2014-07-29 15:37:42.000000000 +0300
> +++ gdb/defs.h 2014-08-09 15:33:59.666750000 +0300
> @@ -628,6 +628,7 @@
> #endif /* alloca not defined */
>
> /* Dynamic target-system-dependent parameters for GDB. */
> +#include "frame.h" /* for 'struct frame_id' */

It is unclear to me why do we need this include?

> #include "gdbarch.h"
>
> /* * Maximum size of a register. Something small, but large enough for
>
> --- gdb/target-dcache.c~0 2014-06-11 19:34:41.000000000 +0300
> +++ gdb/target-dcache.c 2014-08-09 16:17:42.244875000 +0300
> @@ -16,6 +16,7 @@
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> #include "defs.h"
> +#include "target.h" /* for 'enum target_xfer_status' */

enum target_xfer_status isn't used in target-dcache.c. Do we really
need this?

--
Yao (é½å°§)